devnet-8: point dora at the xatu raw + cbt clickhouse - #71
Merged
Conversation
The values hunk matches what ansible-collection-general#582 renders with gen_kubernetes_config_dora_xatu_enabled, so the next regeneration keeps it. Claude-Session: https://claude.ai/code/session_01QTfZjLgwhNK5i4At7BfrBR
There was a problem hiding this comment.
devnet-8 enables dora's xatu block-arrival views: the committed dora values.yaml gains XATU_* extraEnv entries authenticated as pandaops-dora via AVP, and the inventory flips gen_kubernetes_config_dora_xatu_enabled. The values hunk is byte-identical to what ansible-collection-general#582 renders (verified against the actual PR diff, network name substituted), every env var maps to a real dora@master config field, and the network name matches the devnet's xatu event tagging. The one external coupling (ethPandaOps#1546 credential must land first) is already called out in the PR description, so no findings.
Reviewed 2 changed file(s) @ a1a1855f — no blocking issues found.
"It compiles. Ship it."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables dora's xatu block-arrival views on devnet-8. Adds the
XATU_*extraEnv entries to the dora values (raw + cbt ClickHouse through the chproxy endpoints, authenticated as the sharedpandaops-dorauser via AVP), and setsgen_kubernetes_config_dora_xatu_enabledin the devnet-8 inventory. The values hunk is byte-identical to what the template in ethpandaops/ansible-collection-general#582 renders, so regeneration keeps it.